Change in ovirt-engine[master]: webadmin: Add default description to multiple action result

alkaplan at redhat.com alkaplan at redhat.com
Wed Jan 30 15:11:34 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: Add default description to multiple action result
......................................................................


webadmin: Add default description to multiple action result

Each result on multiple action result list can have multiple canDo action
messages.
Today all the canDo action messages are displayed as a bulk and the user
can't understand which message belongs to which action.

To correlate between the action and the message a description should be set
on the result.
For example if the user is trying to remove multiple vms. The description
of each result should be the vm name.

The errors are displayed in the following way-
description1:
  - msg1
  - msg2
description2:
  - msg1

The problem is that not all the commands set description on the returned
value.

This patch checks if there is description, if not, a default one is set-
"Action #num:"

Change-Id: I25495eedf3ec61e11eb3c2bb075833fbcc8f9537
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
2 files changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11453
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25495eedf3ec61e11eb3c2bb075833fbcc8f9537
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>



More information about the Engine-commits mailing list