Change in ovirt-engine[master]: build: checkstyle to disallow final members

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: build: checkstyle to disallow final members
......................................................................


build: checkstyle to disallow final members

Since GWT RPC does not handle final members properly, there is a need to
implement a mechanism to enforce that no member in this package will be
made final by mistake (unless it's a static final constant), as was
done, e.g., in patch I53d6e5bbd66c4d67ec37326b545b65f086600169.

This patch offers such a mechanism by providing a new checkstyle check
which is only configured to run on the common and compat modules.

Change-Id: I809e7f670cf86b47dbd7ae1fc6f73eff9837a129
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
A build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoFinalMemberCheck.java
4 files changed, 61 insertions(+), 0 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I809e7f670cf86b47dbd7ae1fc6f73eff9837a129
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server