Change in ovirt-engine[master]: webadmin: remove redundant null check in importFileSD

tnisan at redhat.com tnisan at redhat.com
Wed Jul 3 09:18:47 UTC 2013


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: remove redundant null check in importFileSD
......................................................................


webadmin: remove redundant null check in importFileSD

importFileStorageAddDomain -> 'sdToAdd' variable can't be null;
it's verified in the calling method (importFileStorageConnect).
Hence, removing null check since findbugs suspect it as a possible NPE
(null shouldn't be passed to StorageDomainManagementParameter ctr).

Change-Id: I62eaff9b2ebffccb938f9db646548d61c4169af8
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16378
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62eaff9b2ebffccb938f9db646548d61c4169af8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list