Change in ovirt-engine[master]: core: Move getOrderedVmGuidsForRunMultipleActions

yzaslavs at redhat.com yzaslavs at redhat.com
Wed Jul 3 10:55:10 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Move getOrderedVmGuidsForRunMultipleActions
......................................................................


core: Move getOrderedVmGuidsForRunMultipleActions

Moved getOrderedVmGuidsForRunMultipleActions(List<Guid>) from DbFacade
(which it has nothing to do with) to VmStaticDao, where it makes sense.
The tests for the method were moved from DbFacadeDAOTest to
VmStaticDAOTest.

A neat side bonus of this refactoring is getting all the capabilities of
BaseDbFacadeDAO for free, allowing the method's code to be made much
clearer.

Change-Id: Ide46b9ad358a5de2815b8d41df2f86f950c9127c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java
6 files changed, 196 insertions(+), 232 deletions(-)

Approvals:
  Allon Mureinik: Verified
  Yair Zaslavsky: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide46b9ad358a5de2815b8d41df2f86f950c9127c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list