Change in ovirt-engine[master]: core: change how async tasks are persisted using TaskHandler...

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Jul 4 07:46:37 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: change how async tasks are persisted using TaskHandlerCommand
......................................................................


core: change how async tasks are persisted using TaskHandlerCommand

Add a way to specify the taskKey of the to-be-persisted task, by
introducing new method that gets the key as a String.

The previous way that was exist for adding async tasks by the
TaskHandlerCommand send the action-type of the enclosing command as the
parent command. this behaviour is now being generalized - the enclosing
command itself will determine whether it should be the parent or other
by override the persist* methods in TaskHandlerCommand interface.

Change-Id: Iee869f68724e67e256e7342f3a5201b7e6d3a30c
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java
7 files changed, 29 insertions(+), 15 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16398
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee869f68724e67e256e7342f3a5201b7e6d3a30c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list