Change in ovirt-engine[master]: webadmin: Refactoring in ProviderModel

alkaplan at redhat.com alkaplan at redhat.com
Tue Jul 9 08:31:27 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: Refactoring in ProviderModel
......................................................................


webadmin: Refactoring in ProviderModel

Removed unnecessary private prefix from variable names to shorten
them, and moved construction of models to the variable declaration to
avoid cluttering in the constructor. This also made redundant their
setters.

Change-Id: Iac82299c44058327eaefc870ec1916d5189bb9e2
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 36 insertions(+), 72 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac82299c44058327eaefc870ec1916d5189bb9e2
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list