Change in ovirt-engine[master]: core: some cleanup in ImportVmCommand

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: some cleanup in ImportVmCommand
......................................................................


core: some cleanup in ImportVmCommand

- Replace AddCanDoActionMessage calls and 'return false' right after
  them with calls to failCanDoAction
- Refactor templateExistsOnExportDomain method to reduce the number of
  nested levels in it
- Rename templateExistsOnExportDomain to isTemplateExistsOnExportDomain
- Refactor updateSnapshotsFromExport method to reduce the number of
  nested levels in it
- Simplified canAddVm method by removing the 'exists' field

Change-Id: Ibfdb7bba0758cfccb55bc237f22659cb1993cc00
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 33 insertions(+), 45 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified
  Liron Ar: Looks good to me, but someone else must approve


-- 
To view, visit http://gerrit.ovirt.org/16296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfdb7bba0758cfccb55bc237f22659cb1993cc00
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server