Change in ovirt-engine[master]: core: Fix double checking

amureini at redhat.com amureini at redhat.com
Mon Jul 15 08:31:13 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix double checking
......................................................................


core: Fix double checking

VdsLoadBalancer.getInstance() implements a double-checking scheme to
initialize the instance static member.

In order for this mechanism to operate correctly, the instance member
should be defined as volatile (see, e.g.,
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html).

Change-Id: I980c2f5117f05bd2b7928b251f730636fc4d26fe
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16810
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I980c2f5117f05bd2b7928b251f730636fc4d26fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list