Change in ovirt-engine[master]: core: Remove object_column_white_list from fixtures.xml

yzaslavs at redhat.com yzaslavs at redhat.com
Mon Jul 15 10:17:11 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Remove object_column_white_list from fixtures.xml
......................................................................


core: Remove object_column_white_list from fixtures.xml

This fixture is not needed. This is a metadata table and is
not changing within tests.
It should be created by create_schema.sh and be left as is.
A fix was also inserted to the whitelist sql, to change
sshkeyfingerpint to be lowercase so VdsDAOTest will not break.
The breakage of VdsDAOTest exposed that a non privileged user could
get the ssh key fingerprint.

Change-Id: I6f0429c322f923f0b3c725270aa51c121ca27129
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
2 files changed, 1 insertion(+), 350 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f0429c322f923f0b3c725270aa51c121ca27129
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list