Change in ovirt-engine[master]: userportal, webadmin: Don't bundle gwt-dev.jar

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Jul 23 18:38:56 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: userportal, webadmin: Don't bundle gwt-dev.jar
......................................................................


userportal, webadmin: Don't bundle gwt-dev.jar

The GWT RPC mechanism that we currently use needs some classes that are
part of the gwt-dev.jar file since version 2.5.1. This means that we
need to add that gwt-dev.jar file to the WEB-INF/lib directories of the
applications, and that causes class loading problems because gwt-dev.jar
bundles many third party libraries, including its own copy of the Xerces
XML parser. To avoid this issue we are copying into the frontend project
the sources of the classes needed by the GWT RPC mechanism and not
included in gwt-servlet.jar, currently only
com.google.gwt.core.client.GWTBridge. This way we can set the scope of
the gwt-dev dependency to provided so that it won't be included in the
WEB-INF/lib directories.

Change-Id: I0555b185ea8c52469ebe0779f5287b5bd824a569
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M frontend/webadmin/modules/frontend/pom.xml
A frontend/webadmin/modules/frontend/src/main/java/com/google/gwt/core/client/GWTBridge.java
M pom.xml
3 files changed, 38 insertions(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/17264
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0555b185ea8c52469ebe0779f5287b5bd824a569
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list