Change in ovirt-engine[master]: host-deploy: InstallVdsCommand: remove redundant case

yzaslavs at redhat.com yzaslavs at redhat.com
Tue Jul 30 15:09:04 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: host-deploy: InstallVdsCommand: remove redundant case
......................................................................


host-deploy: InstallVdsCommand: remove redundant case

switch is going over all cases, in case of 'default' we actually have
internal error.

having case without break with logic within is not best practice for
procedural programming as there are two entries into single block.

for now just remove that case.

Change-Id: I45a7294e582ed24159d749be069533fb5f44f855
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/17414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45a7294e582ed24159d749be069533fb5f44f855
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list