Change in ovirt-engine[master]: frontend: Fix SearchableListModel.getSearchString()

vszocs at redhat.com vszocs at redhat.com
Wed Jul 31 12:09:53 UTC 2013


Vojtech Szocs has submitted this change and it was merged.

Change subject: frontend: Fix SearchableListModel.getSearchString()
......................................................................


frontend: Fix SearchableListModel.getSearchString()

Commit caef3ae [frontend: Add paging in SubTabPoolVmView] has
modified SearchableListModel.getSearchString() implementation
so that it returns "null" (String) instead of null (literal)
when searchString field is null.

In practice, GUI bound to SearchableListModel.searchString
via GWT Editor framework now shows "null" (String) instead
of empty string (due to null literal) when searchString field
is null, for example:

Data Center main tab | Permission sub tab | Add button
-> text box left to "GO" button now shows "null" string

This patch fixes the above mentioned problem by ensuring
getSearchString() returns null (instead of "null") when
searchString field is null.

Change-Id: I2fc2cab5785597cd7a7c9602a967250f16742489
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/17504
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fc2cab5785597cd7a7c9602a967250f16742489
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list