Change in ovirt-engine[master]: webadmin: avoid multiple failovers caused by import subtabs ...

derez at redhat.com derez at redhat.com
Sun Jun 2 06:19:48 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: avoid multiple failovers caused by import subtabs auto-refresh
......................................................................


webadmin: avoid multiple failovers caused by import subtabs auto-refresh

The SubTabStorageTemplateBackupView/SubTabStorageVmBackupView subtabs
executes an engine query to display the vms/templates that exist on the
selected export domain - this engine query executes an spm command
(GetVmsInfoVDSCommand) which will attempt to perform failover in case of
failure.
The fact that the query is being executed every 5 seconds, causes to the
requests to "pile up" and possibly perform multiple failovers, Therefore
the automatic refresh to the tab has been replaced with manual refresh button.

Change-Id: I2668a60b5b33b2ca8d82b9d08c477ba7c1a3a723
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
3 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2668a60b5b33b2ca8d82b9d08c477ba7c1a3a723
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>



More information about the Engine-commits mailing list