Change in ovirt-engine[master]: core: Remove TestHelperImportVmTemplateCommand

amureini at redhat.com amureini at redhat.com
Wed Jun 5 08:38:09 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove TestHelperImportVmTemplateCommand
......................................................................


core: Remove TestHelperImportVmTemplateCommand

TestHelperImportVmTemplateCommand is an old helper class used to set up
mocking for ImportVmTemplateCommandTest.

Since all this mocking is already done in the test itself (albeit a
slight refactoring was required to make it available), this helper is no
longer needed, and should be removed.

Change-Id: I35bacd6bcd5fa7bbfd709ec2a8fbd0bb529536a3
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java
2 files changed, 12 insertions(+), 124 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35bacd6bcd5fa7bbfd709ec2a8fbd0bb529536a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list