Change in ovirt-engine[engine_3.2]: pki: remove database config upgrade

oschreib at redhat.com oschreib at redhat.com
Tue Jun 11 10:27:18 UTC 2013


Ofer Schreiber has submitted this change and it was merged.

Change subject: pki: remove database config upgrade
......................................................................


pki: remove database config upgrade

BACKGROUND

There is a bug in engine-config that existed since beginning of time, it
does not take the CABaseDirectory into account.
However, both the setup and the upgrade set full path for all pki
artifacts, this is why this bug has been never discovered.

DESCRIPTION

The database upgrade script puts two values per default, these are
relative:
select
fn_db_update_config_value('keystoreUrl','keys/engine.p12','general');
select
fn_db_update_config_value('TruststoreUrl','.truststore','general');

When system is upgraded from 3.1, after database upgrade the
engine-upgrade script will convert keys to PKCS#12 format, and overwrite
database settings.

However, if you upgrade from 3.2 to 3.2, then the engine-upgrade script
does not overwrite the setting, leaving relative paths.

WORKAROUND

Modify keystoreUrl and truststoreUrl within database to absolute paths.

Change-Id: Iec8bb367033b5ec03b5b97bd183fc5683523ccd9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=968906
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec8bb367033b5ec03b5b97bd183fc5683523ccd9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list