Change in ovirt-engine[master]: findbugs: Consider making the field static

shavivi at redhat.com shavivi at redhat.com
Wed Jun 12 09:07:03 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: Consider making the field static
......................................................................


findbugs: Consider making the field static

This class contains an instance final field that is initialized to a
compile-time static value.

SS: Unread field: should this field be static? (SS_SHOULD_BE_STATIC)

Change-Id: I8c2a7b2265966d426520880c102074c6e7bfddea
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabTree.java
8 files changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c2a7b2265966d426520880c102074c6e7bfddea
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>



More information about the Engine-commits mailing list