Change in ovirt-engine[master]: findbugs: dont use static filed as public

shavivi at redhat.com shavivi at redhat.com
Thu Jun 13 12:29:21 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: dont use static filed as public
......................................................................


findbugs: dont use static filed as public

A mutable static field could be changed by malicious code or by
accident. The field could be made package protected to avoid this
vulnerability.

findbugs reason:
MS: Field should be package protected (MS_PKGPROTECT)

Change-Id: If0d3d345fdd56faf1a7b9ae826924527f6fceff2
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DefaultRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPAGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPARootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPAUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSUserContextMapper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
19 files changed, 22 insertions(+), 22 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0d3d345fdd56faf1a7b9ae826924527f6fceff2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list