Change in ovirt-engine[master]: findbugs: Suspicious reference comparison of Boolean values

shavivi at redhat.com shavivi at redhat.com
Mon Jun 17 13:47:27 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: Suspicious reference comparison of Boolean values
......................................................................


findbugs: Suspicious reference comparison of Boolean values

commit dcc771b2ad21bea0caecaef79cf26daaa8ecc229 fix reference comparison
of Boolean values.
I GWT debugging we are getting NPE because the new comparison of
consoleAddressPartiallyOverridden null value to false, hence not setting
it to false.

This patch add default value to false and change the
isConsoleAddressPartiallyOverridden() to return false instead of null

Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15790
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>



More information about the Engine-commits mailing list