Change in ovirt-engine[master]: core: introducing virtio-scsi support

[derez at redhat.com]

Daniel Erez has submitted this change and it was merged.

Change subject: core: introducing virtio-scsi support
......................................................................


core: introducing virtio-scsi support

A new DiskInterface type: VirtIO_SCSI
* Available for both DiskImage and LunDisk
* Supported for Cluster 3.3 and above
- Added 'VirtIoScsiEnabled' ConfigValue
* OS Guest support
- Added 'VirtIoScsiUnsupportedOsList' ConfigValue
* VmInfoBuilder - adapting to VDSM API
- Interface attribute: iface='scsi'
- Controller element is sent when required
  (if there's at least one disk with virtio-scsi interface)

SGIO [1]
* Avaiable for DirectLUN disks with VirtIO-SCSI interface
* Added ScsiGenericIO enum: filtered/unfiltered
* Added 'sgio' column to 'base_disks' table
- Updated relevant views:
  vm_images_storage_domains_view, images_storage_domain_view
  storage_for_image_view, all_disks
* Should be restricted by MLA permissions
- A new ActionGroup: CONFIGURE_SCSI_GENERIC_IO
- Granted to DataCenterAdmin and SuperUser roles
- Verified on AddDiskCommand and UpdateVmDiskCommand
* VmInfoBuilder - adapting to VDSM API
- 'sgio' attribute on disk element

[1] 'sgio': SCSI Generic IO - filtered/unfiltered
(indicates whether the OS kernel will filter unprivileged
SG_IO commands for the disk).

* Feature page: http://www.ovirt.org/Features/Virtio-SCSI

Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/dbscripts/base_disks_sp.sql
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_03_0260_add_base_disks_sgio_column.sql
A backend/manager/dbscripts/upgrade/03_03_0270_add_permission_to_configure_sgio.sql
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ScsiGenericIO.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
30 files changed, 362 insertions(+), 36 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/14906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server