Change in ovirt-engine[master]: webadmin: Consolidated move & copy disk availability checks

tnisan at redhat.com tnisan at redhat.com
Sun Jun 23 09:29:31 UTC 2013


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Consolidated move & copy disk availability checks
......................................................................


webadmin: Consolidated move & copy disk availability checks

The logic for checking whether moving a disk or copying a disk is allowed
was all the same except for the check whether the disk is used as a
template disk or not, both checks were consolidated to a single check
to avoid redundant checks on the same disks and for better code reuse

Change-Id: Ieb3c388aecc5b007a76c54ed0d41105bc28ebb51
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 27 insertions(+), 40 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb3c388aecc5b007a76c54ed0d41105bc28ebb51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list