Change in ovirt-engine[master]: engine: Added check that provider networks unused

mkolesni at redhat.com mkolesni at redhat.com
Mon Jun 24 06:28:01 UTC 2013


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Added check that provider networks unused
......................................................................


engine: Added check that provider networks unused

Added a limitation that provider cannot be removed if it has a network
that is being used by a VM/template, in order not to incapacitate that
VM/template (since without a provider, the network is unusable).

Change-Id: I9e0c0c5c1cb52109b71cac29b95b25f34977a11c
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/dbscripts/network_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/RemoveProviderValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 210 insertions(+), 3 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/13570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e0c0c5c1cb52109b71cac29b95b25f34977a11c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list