Change in ovirt-engine[master]: core: refactoring VdsSelector API

gchaplik at redhat.com gchaplik at redhat.com
Mon Jun 24 11:38:26 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: refactoring VdsSelector API
......................................................................


core: refactoring VdsSelector API

Host selection should become stateless, therefore moving failed host
list out of this class (vdsBlackList), and pass it as a parameter.
In addition, each vdsSelector call should supply a list of hosts
that the selector should 'work' on.

new VdsSelector API:
// for Validation purposes
canFindVdsToRunOn(List<VDS> vdsList,
            List<Guid> vdsBlackList,
            List<String> messages,
            boolean isMigrate)
//  for selecting a host to run on
Guid getVdsToRunOn(List<VDS> vdsList,
            List<Guid> vdsBlackList,
            boolean isMigrate)

Gerrit-cntr: 1
Change-Id: I6d936e1b96628e426e944d77730e3ca08a1357ee
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
7 files changed, 109 insertions(+), 76 deletions(-)

Approvals:
  Laszlo Hornyak: Looks good to me, approved
  Gilad Chaplik: Verified


-- 
To view, visit http://gerrit.ovirt.org/16030
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d936e1b96628e426e944d77730e3ca08a1357ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>



More information about the Engine-commits mailing list