Change in ovirt-engine[master]: core: Return source string if blank is passed

yzaslavs at redhat.com yzaslavs at redhat.com
Sun Jun 30 06:31:39 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Return source string if blank is passed
......................................................................


core: Return source string if blank is passed

Patch e0b50e8f4caef63f42d192457f1b8a8d6390a379 Removed EncryptionUtils
and introduced EngineEncryptionUtils.
It also inadvertently introduced a behaviour change in the
encrypt/decrypt methods - returning "" if the given string was blank
instead of the old behaviour of returning null if the original was null.
Note that this change broke the DAO tests

This patch returns the old behaviour in order to allow the DAO tests to
run.

Change-Id: If2882371e84c92b0e087a5db8658512ae7875e52
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Allon Mureinik: Verified
  Yair Zaslavsky: Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2882371e84c92b0e087a5db8658512ae7875e52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list