Change in ovirt-engine[master]: core: Fix modifiers of getStrRepresentationOfGuid

amureini at redhat.com amureini at redhat.com
Sun Jun 30 07:53:51 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix modifiers of getStrRepresentationOfGuid
......................................................................


core: Fix modifiers of getStrRepresentationOfGuid

This method is not used outside of the Guid class, and hence should be
private.

It also does not access any member variables, so it should be static.

Change-Id: I7ca9ed63077fc5a7c39c38900780afd14126fffc
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ca9ed63077fc5a7c39c38900780afd14126fffc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list