Change in ovirt-engine[master]: core: Remove Guid.OpEquals(Guid, Guid)

amureini at redhat.com amureini at redhat.com
Sun Jun 30 07:53:52 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove Guid.OpEquals(Guid, Guid)
......................................................................


core: Remove Guid.OpEquals(Guid, Guid)

OpEquals was only used in two places in the codebase, and both have at
least one value known to be non-null.
Hence, this method could be removed, and replaced by a simple call to
Guid.equals(Object).

Change-Id: I3c0f79f2161f4beca5b048ca74acaf63c11753e3
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
3 files changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15690
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c0f79f2161f4beca5b048ca74acaf63c11753e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list