Change in ovirt-engine[master]: webadmin: Clean up RpmVersion comparing

amureini at redhat.com amureini at redhat.com
Sun Jun 30 16:16:45 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Clean up RpmVersion comparing
......................................................................


webadmin: Clean up RpmVersion comparing

RpmVersionComparaer just returns the natural ordering of RpmVersion, and
is thus redundant and should be removed.

Instead of calling the soon to be delete Linq.orderByDescending, Java's
built in Collection.reverseOrder() is used to sort the list of
RpmVersions more efficiently.

Change-Id: I5e2fb041d3254ae5629972efa882462dd8f941d4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
2 files changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16265
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e2fb041d3254ae5629972efa882462dd8f941d4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list