Change in ovirt-engine[master]: engine: Introducing Nameable Comparator

amureini at redhat.com amureini at redhat.com
Sun Jun 30 16:16:46 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Introducing Nameable Comparator
......................................................................


engine: Introducing Nameable Comparator

Introduced the NameableComparator which compares Nameables by their
name, and used wherever possible to replace duplicate code in Linq.

Subsequent patches will make more classes Nameables and remove more
duplications.

Change-Id: Iefff7c751c8ed009be1505da75e18485db399a71
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/NameableComparator.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
6 files changed, 23 insertions(+), 24 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefff7c751c8ed009be1505da75e18485db399a71
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list