Change in ovirt-engine[master]: core: ImagesHandler: filterImageDisks readability

amureini at redhat.com amureini at redhat.com
Sun Mar 3 12:25:04 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImagesHandler: filterImageDisks readability
......................................................................


core: ImagesHandler: filterImageDisks readability

Improved readability of ImagesHandler.filterImageDisks:
1. Reordered the evaluated conditions
2. Changed the terminology from "filter", which may be ambiguous to
   "allowOnly".

Change-Id: I7cc2fc314e05fda6b1c6cdf39365b64fa0cfe345
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7cc2fc314e05fda6b1c6cdf39365b64fa0cfe345
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list