Change in ovirt-engine[master]: webadmin: Rewrote arranging of NICs in Host/Networks subtab

alkaplan at redhat.com alkaplan at redhat.com
Mon Mar 4 09:08:47 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: Rewrote arranging of NICs in Host/Networks subtab
......................................................................


webadmin: Rewrote arranging of NICs in Host/Networks subtab

This patch includes:
* Some needed refactoring.
* Sorting of NICs by name using LexoNumericComparator.
* Removal of HostVLanByNameComparer class which is no longer used.
* Improvement of computational complexity - old code was naive and would
  perform in O(n^2), reduced to O(nlogn) bounded by sorting.

Change-Id: I0b464cc023282ceab868230a1c31638ebe75de4d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883269
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLanByNameComparer.java
3 files changed, 135 insertions(+), 108 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12000
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b464cc023282ceab868230a1c31638ebe75de4d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list