Change in ovirt-engine[master]: core: Removed GetTagIdsAndChildrenIdsByRegExp refs

amureini at redhat.com amureini at redhat.com
Wed Mar 6 07:25:25 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Removed GetTagIdsAndChildrenIdsByRegExp refs
......................................................................


core: Removed GetTagIdsAndChildrenIdsByRegExp refs

GetTagIdsAndChildrenIdsByRegExp seems to have been a useful function in
oVirt 3.0, but it has since been (partially) removed, and is not called
from anywhere.
This patch removes the leftovers of that partial cleanup.

This patch removes:
* The function in TagsDirector (was only used by the function of the
  same name in TagsHandler and in tests)
* The function in TagsHandler and its interface, ITagsHandler (wasn't
  used anywhere)
* The constant in VdcQueryType (useless, has no corresponding query
  object)

Change-Id: I1f7a7ab04a5c1a9fc1104d0ddb2d3a3a8ec0f1e0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ITagsHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
5 files changed, 4 insertions(+), 80 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f7a7ab04a5c1a9fc1104d0ddb2d3a3a8ec0f1e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list