Change in ovirt-engine[master]: core: disable everyone for login

oourfali at redhat.com oourfali at redhat.com
Thu Mar 7 11:54:36 UTC 2013


Oved Ourfali has submitted this change and it was merged.

Change subject: core: disable everyone for login
......................................................................


core: disable everyone for login

If the "everyone" has assignd a role which contains login,
from this point everyone is allowed to log in.

In this specific bug the NetworkUser has been assigned to
everyone which contained the login. This caused that everyone
was allowed to log in. This issue did not happened the first time
so this patch solves it in a more generic way - ignores the
everyone when checking if the user is allowed to log in.

Change-Id: I7bba37a450efdd9e3475470e4ed8f49347c51a2e
Bug-Url: https://bugzilla.redhat.com/916328
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/dbscripts/multi_level_administration_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
5 files changed, 12 insertions(+), 9 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Oved Ourfali: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12830
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bba37a450efdd9e3475470e4ed8f49347c51a2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list