Change in ovirt-engine[master]: core: remove duplicate event on successful hibernation

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Mar 11 07:39:14 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: remove duplicate event on successful hibernation
......................................................................


core: remove duplicate event on successful hibernation

Successful hibernation (suspension) of VM resulted in three events:
1. event that indicates that the action was initiated
2. event that indicates that the action was completed
3. event that indicates that the VM is suspended

The second event was generated by the command and the third event was
generated by the monitoring. those two messages are expressing the same
thing so we don't need both of them.

Moreover, the second event is misleading because the command generates
it right after sending the request to VDSM, thus it can't say that the
action is completed at that point. so this patch removes the second
event.

Change-Id: I5445374ddf6996e696c71995fe3bd2a9ddd60a85
Bug-Url: https://bugzilla.redhat.com/918306
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 17 insertions(+), 7 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified


--
To view, visit http://gerrit.ovirt.org/12838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5445374ddf6996e696c71995fe3bd2a9ddd60a85
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>



More information about the Engine-commits mailing list