Change in ovirt-engine[master]: core: UpdateVmDiskCommand: remove DbFacade calls

amureini at redhat.com amureini at redhat.com
Tue Mar 12 10:14:47 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: UpdateVmDiskCommand: remove DbFacade calls
......................................................................


core: UpdateVmDiskCommand: remove DbFacade calls

Replaced DbFacade.getXXXDao() calls with getXXDao() calls for better
readability and testability.

Wherever appropriate, these getXXDao methods were applied to
AbstractDiskVmCommand.

Relates-To: https://bugzilla.redhat.com/854964
Change-Id: Id31bc1234ed109f9cb1ae658572b4b2e67c6f6ee
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
3 files changed, 6 insertions(+), 15 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id31bc1234ed109f9cb1ae658572b4b2e67c6f6ee
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list