Change in ovirt-engine[master]: engine: Optimyzing RemoveVds

mkublin at redhat.com mkublin at redhat.com
Wed Mar 13 12:52:35 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Optimyzing RemoveVds
......................................................................


engine: Optimyzing RemoveVds

The following patch will improve canRemoveVds method of RemoveVdsCommand.
The change will reduce a number of queries and will make code more clear.
Also removed duplicate check inside execute() - it will not prevent a race,
but it always reduce performance

Change-Id: Id2a11727041955aeda1940fca1f27c616f46135f
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
1 file changed, 39 insertions(+), 60 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12997
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2a11727041955aeda1940fca1f27c616f46135f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list