Change in ovirt-engine[master]: frontend: VM Linux Boot options aren't parsing properly

tjelinek at redhat.com tjelinek at redhat.com
Wed Mar 13 14:10:07 UTC 2013


Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: VM Linux Boot options aren't parsing properly
......................................................................


frontend: VM Linux Boot options aren't parsing properly

- added checking Linux Boot options in the Run Once dialog.
- slightly refactored validity checking to improve code readibility
- also fixed the error when the invalidity messages in "kernel params" and
  "initrd path" fields weren't displayed (caused by setting invalidity
  flag before setting invalidity message)

Change-Id: I23bd3ee3677c9bdbfacf1cf341dc1d97fd57c65e
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872178
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
4 files changed, 58 insertions(+), 118 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12494
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23bd3ee3677c9bdbfacf1cf341dc1d97fd57c65e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list