Change in ovirt-engine[master]: core: Remove unused GetDisksForQuotaIdQuery

amureini at redhat.com amureini at redhat.com
Mon Mar 18 12:14:28 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove unused GetDisksForQuotaIdQuery
......................................................................


core: Remove unused GetDisksForQuotaIdQuery

GetDisksForQuotaIdQuery is not used anywhere in the code, and hence
should be removed.

This patch removes the following:
1. The GetDisksForQuotaIdQuery class
2. The GetDisksForQuotaIdParameters class used by said query
3. The GetDisksForQuotaId constant representing it in VdcQueryType
4. The getAllForQuotaId(Guid) method in DiskImageDAO (which was only
   used by the query), its implementation, and its test.
5. The GetImagesByQuotaId(UUID) stored procedure that was only used by
   the said DAO function.

Change-Id: I77f8c0a54fbcdc150234888d73a941088376ef3e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/dbscripts/disk_images_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDisksForQuotaIdQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDisksByQuotaIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java
7 files changed, 0 insertions(+), 77 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77f8c0a54fbcdc150234888d73a941088376ef3e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list