Change in ovirt-engine[master]: core: add locking groups for resources in export domain

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Mar 20 15:04:19 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: add locking groups for resources in export domain
......................................................................


core: add locking groups for resources in export domain

Until now we used the TEMPLATE & VM locking groups to lock those
resources in data domains as well as in export domain. it lead to
unnecessary restrictions, for example: we couldn't remove template
from data domain while it is being removed from export domain.

Now that we don't have to put locks in the DB anymore, we can split the
locks of resources in data domains from the locks of those resources
in the export domain by creating two different locking groups.

This patch introduces two new locking groups: REMOTE_TEMPLATE & REMOTE_VM
which will be used to lock templates/VMs in the export domain.

This patch also removes unnecessary code from getSharedLocks method in
AddVmFromTemplateCommand class that was lately added.

Change-Id: I1877ecce86198f8c9345f5d35820121866c3dfe0
Bug-Url: https://bugzilla.redhat.com/920150
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified


--
To view, visit http://gerrit.ovirt.org/13102
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1877ecce86198f8c9345f5d35820121866c3dfe0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>



More information about the Engine-commits mailing list