Change in ovirt-engine[master]: core: unify the GetAllImagesList queries

amureini at redhat.com amureini at redhat.com
Fri Mar 22 11:28:41 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: unify the GetAllImagesList queries
......................................................................


core: unify the GetAllImagesList queries

This patch unifies and consolidates the queries to retrieve the list of
images from a storage domain. The previous separate queries were:

 GetAllImagesList
 GetAllIsoImagesList
 GetAllIsoImagesListByStoragePoolId
 GetAllFloppyImagesList
 GetAllFloppyImagesListByStoragePoolId

which have been consolidated in:

 GetImagesList (renamed from GetAllImagesList)
 GetImagesListByStoragePoolId

The type of image to list (iso, vfd) is now a parameter that can allow
also additional types (e.g.: disk) and a generic "All" to retrieve the
entire list.

This is one of the first steps toward image storage domains that can
store any type of images (iso, vfd, disk, etc...).

Change-Id: I079e3f1c5bfbcfd1dc09ebce41a327c253eb53ac
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGetAllImagesListByStorageDomainIdQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGetAllImagesListQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllFloppyImagesListByStoragePoolIdQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllFloppyImagesListQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllImagesListQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllIsoImagesListByStoragePoolIdQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllIsoImagesListQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FileTypeExtension.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllImagesListByStoragePoolIdParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllImagesListParametersBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllIsoImagesListParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListByStoragePoolIdParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
26 files changed, 215 insertions(+), 285 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13066
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I079e3f1c5bfbcfd1dc09ebce41a327c253eb53ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>



More information about the Engine-commits mailing list