Change in ovirt-engine[master]: engine: fixed NPE in add host

sanjal at redhat.com sanjal at redhat.com
Mon Mar 25 13:16:16 UTC 2013


Shireesh Anjal has submitted this change and it was merged.

Change subject: engine: fixed NPE in add host
......................................................................


engine: fixed NPE in add host

The patch http://gerrit.ovirt.org/13001 modified setVds to set the
mVdsId to Empty in case VDS is passed as null. This results in an
NPE as AddVdsCommand explicitly sets VDS to null, and later calls
getVdsIdRef(), expecting it to be null, but is now Empty.

Hence modifying setVds() to not set it to Empty in case of null, but
leave it as null itself.

Change-Id: I369203472969e707cb515bf593f12849b13b694c
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Shireesh Anjal: Verified


--
To view, visit http://gerrit.ovirt.org/13325
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I369203472969e707cb515bf593f12849b13b694c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list