Change in ovirt-engine[master]: webadmin: Control UI plugin dynamic tab alignment

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Control UI plugin dynamic tab alignment
......................................................................


webadmin: Control UI plugin dynamic tab alignment

This patch improves the existing UI plugin API for handling
dynamic tabs.

(1) Function improved: addMainTab

New signature:
    addMainTab(label, historyToken, contentUrl [, options])

Example usage:

    // Tab is left-aligned by default
    addMainTab('Foo Tab', 'foo-tab', 'http://www.foo.com/');

    // Tab is right-aligned via options object
    addMainTab('Foo Tab', 'foo-tab', 'http://www.foo.com/', {
        alignRight: true
    });

(2) Function improved: addSubTab

New signature:
    addSubTab(entityTypeName, label, historyToken, contentUrl
        [, options])

Example usage:

    // Tab is left-aligned by default
    addSubTab('VirtualMachine',
        'Bar Tab', 'bar-tab', 'http://www.bar.com/');

    // Tab is right-aligned via options object
    addSubTab('VirtualMachine',
        'Bar Tab', 'bar-tab', 'http://www.bar.com/', {
            alignRight: true
        }
    );

Signed-off-by: Spenser Shumaker <sshumake at redhat.com>
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
Change-Id: Icd6929538fd106d0c54d162dfd21f8946254ce5f
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabProxy.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/DynamicTab.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/DynamicTabData.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/TabOptions.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxy.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxyFactory.java
8 files changed, 69 insertions(+), 29 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11273
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd6929538fd106d0c54d162dfd21f8946254ce5f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Spenser Shumaker <sshumake at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts at redhat.com>
Gerrit-Reviewer: Spenser Shumaker <sshumake at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>