Change in ovirt-engine[master]: userportal, webadmin: bring back change CD menu to SPICE cons...

tjelinek at redhat.com tjelinek at redhat.com
Mon May 6 11:18:22 UTC 2013


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal,webadmin: bring back change CD menu to SPICE console
......................................................................


userportal,webadmin: bring back change CD menu to SPICE console

This has been lost while moving from 3.0 to 3.1.

This patch contains:
- setting the correct menu to the ActiveX plugin (XPI
plugin does not have this functionality)
- listening to the onmenuitemselected event and firing the correct
event in response
- fix the menu item creation - new StringBuilder(int) just creates the
empty string (int param means the capacity, not the actual content)
- fix the format of the menu
- removed items which are not handled by us anymore, but handled
by the spice client itself

Change-Id: Ifdfa982da00ae333271f60795b0c17fe602e14ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957611
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceMenu.java
3 files changed, 11 insertions(+), 27 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14407
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdfa982da00ae333271f60795b0c17fe602e14ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list