Change in ovirt-engine[master]: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand

mkublin at redhat.com mkublin at redhat.com
Mon May 6 12:46:54 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
......................................................................


engine: Fixing NPE in CollectVdsNetworkDataVDSCommand

The NPE is occuring because of some changes in Base class.
As a fix, start to pass a VDS as parameter and not vdsId

Change-Id: I9d3027b134e11e9fb22cd007d10ce4b9fd8afbb6
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
7 files changed, 11 insertions(+), 16 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14501
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3027b134e11e9fb22cd007d10ce4b9fd8afbb6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list