Change in ovirt-engine[master]: root: use %{x} notation instead of ${x} in web.xml

yzaslavs at redhat.com yzaslavs at redhat.com
Wed May 8 09:41:30 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: root: use %{x} notation instead of ${x} in web.xml
......................................................................


root: use %{x} notation instead of ${x} in web.xml

rhel jboss, at least 7.1.3-4, perform unconditional properties ${x}
substitutions in web.xml, while fedora jboss at least 7.1.1-9.3, does
not.

a solution for rhel jboss is to use $${x}, while this solution is not
working for fedora jboss.

to allow common processing and future migration to other application
server the notation was changed to %{x}.

Related-Change-Id: I94f845d36bb075c238e50606187bc22316713cdd
Change-Id: I115118e6f46ac74bc882949e101bbe3d04e29684
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java
M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
3 files changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I115118e6f46ac74bc882949e101bbe3d04e29684
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list