Change in ovirt-engine[master]: engine: custom properties: allow '=' in regex

gchaplik at redhat.com gchaplik at redhat.com
Mon May 13 17:50:58 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: engine: custom properties: allow '=' in regex
......................................................................


engine: custom properties: allow '=' in regex

In custom properties sheet when regex contains '=', we cannot parse
the string using split('=') (the parsing is invalid).
To solve that added a hard limit of 2 for the string split.

Bug-Url: https://bugzilla.redhat.com/956467
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
4 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list