Change in ovirt-engine[master]: gluster: set service name&type in ServerServiceDAO

sanjal at redhat.com sanjal at redhat.com
Tue May 14 07:00:09 UTC 2013


Shireesh Anjal has submitted this change and it was merged.

Change subject: gluster: set service name&type in ServerServiceDAO
......................................................................


gluster: set service name&type in ServerServiceDAO

Introduced new view gluster_server_services_view with additional columns
for service_name and service_type.

Updated SPs to fetch from this view instead of the table. (Removed one
duplicate SP in this process)

Modified GlusterServerServiceRowMapper in the DAO to populate service
name and type. Also updated the test case to verify this.

Change-Id: I6a4706aae779e73b4aae7ca5810fe998559f62a4
Signed-off-by: Shireesh Anjal <anjalshireesh at gmail.com>
---
M backend/manager/dbscripts/create_views.sql
M backend/manager/dbscripts/gluster_services_sp.sql
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoTest.java
4 files changed, 31 insertions(+), 20 deletions(-)

Approvals:
  Shireesh Anjal: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14608
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a4706aae779e73b4aae7ca5810fe998559f62a4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>



More information about the Engine-commits mailing list