Change in ovirt-engine[master]: findbugs: assigned value never used

shavivi at redhat.com shavivi at redhat.com
Thu May 16 11:49:35 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: assigned value never used
......................................................................


findbugs: assigned value never used

Assigning Guid.Empty to vmToAttach, but it never used.
We override this value in the next statement.

findbugs code:
DLS: Dead store to local variable that shadows field

Change-Id: I42dd82224a31840157cfcbd499e91f607830bc06
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Shahar Havivi: Verified
  Oved Ourfali: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42dd82224a31840157cfcbd499e91f607830bc06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>



More information about the Engine-commits mailing list