Change in ovirt-engine[master]: core: Removing template with disks ends with unused data in ...

amureini at redhat.com amureini at redhat.com
Mon May 20 08:58:32 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Removing template with disks ends with unused data in the db
......................................................................


core: Removing template with disks ends with unused data in the db

When removing a template, the records of its disks weren't deleted from
base_disks table because the call to the delete stored procedure was done
with the id of the image rather then the id of the disk - which caused
to unused records to be left in the table and possible errors when
trying to import the template again (not as a clone).

Change-Id: I86573e91885085bcdfc30ee4e966590901a62067
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Liron Ar: Verified


--
To view, visit http://gerrit.ovirt.org/14877
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86573e91885085bcdfc30ee4e966590901a62067
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list