Change in ovirt-engine[master]: core: remove SearchReturnValue

[lhornyak at redhat.com]

Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: remove SearchReturnValue
......................................................................


core: remove SearchReturnValue

SearchReturnValue extends VdcQueryReturnValue and adds the boolean
isSearchValid. However, this boolean is only set in various flows, and
never read, meaning this entire class is useless.

This patch does the following:
1. Removes SearchReturnValue
2. Removes QueriesCommandBase.createReturnValue() and replaces it with
   an inline call to new VdsQueryReturnValue(), since now there is no
   reason to override it.
3. Removes QueriesCommandBase.proceedOnFail(), since now no class
   implements it.

Change-Id: I39fd1f1fb4bf66e594ea3157bd36959736faa6dc
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LdapSearchQueryTestBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchReturnValue.java
4 files changed, 7 insertions(+), 58 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39fd1f1fb4bf66e594ea3157bd36959736faa6dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>