Change in ovirt-engine[ovirt-engine-3.3]: core: [TEXT] restore.sh woes, unable to...

iheim at redhat.com iheim at redhat.com
Wed Nov 6 13:15:51 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core:  [TEXT] restore.sh woes, unable to...
......................................................................


core:  [TEXT] restore.sh woes, unable to...

[TEXT] restore.sh woes, unable to restore engine DB without using -u postgres

1) removing the internal create/drop of the database, this should be
done manually as explained in the script usage statement
2) adding a comment that this script will work only for DB engine user
3) removing from backup script the -C flag to prevent database creation
statements generation
4) If an old backup having "CREATE DATABASE" or "ALTER DATABASE" is
used, those statements are removed before an attempt to restore the
database is done.

Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=976337
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M packaging/dbscripts/backup.sh
M packaging/dbscripts/restore.sh
2 files changed, 36 insertions(+), 31 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20929
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list