Change in ovirt-engine[master]: webadmin: Small refactoring to simplify VnicProfileModel

lvernia at redhat.com lvernia at redhat.com
Thu Nov 7 10:33:18 UTC 2013


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Small refactoring to simplify VnicProfileModel
......................................................................


webadmin: Small refactoring to simplify VnicProfileModel

It wasn't really clear what exactly dcId and dcCompatibilityVersion
were affecting, whereas customPropertiesVisible was passed around as a
parameter when it really should only be set when the VnicProfileModel
is constructed.

Also theoretically improved the behavior of selecting a QoS
configuration from the list. Currently when editing a network the DC
can't be changed, but if that is enabled in the future, then if the DC
will be switched and then switched back, the original QoS selection
will be salvaged.

Change-Id: I8e98a1fc26ce6b32076e09a67e6a3d82f52964df
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
2 files changed, 29 insertions(+), 22 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20749
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e98a1fc26ce6b32076e09a67e6a3d82f52964df
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list